[alsa-devel] [PATCH] powerpc: select PPC_CLOCK unconditionally for FSL_SOC

[Kumar Gala]

On Apr 4, 2012, at 8:32 AM, Shawn Guo wrote:

> Kumar,
> 
> Gentle ping ...
> 
> Regards,
> Shawn

Was on a bit of travel to nowhere, but that's a different story.

What timeframe are you looking for this to go in? 3.4 or 3.5?

- k

> 
> On Fri, Mar 30, 2012 at 01:38:56PM +0800, Shawn Guo wrote:
>> Freescale PowerPC SoCs share a number of IP blocks with Freescale
>> ARM/IMX SoCs, FlexCAN, SSI, FEC, eSDHC, USB, etc.  There are some
>> effort consolidating those drivers to make them work for both
>> architectures.
>> 
>> One outstanding difference between two architectures is ARM/IMX will
>> turn off module clocks during platform initialization for power saving
>> and expects drivers manage clocks using clk API, while PowerPC
>> mostly does not do that, and thus does not always build in clk API.
>> 
>> Listing all those driver Kconfig options in "select PPC_CLOCK if" seems
>> not scalable for long term maintenance, and could easily introduce
>> Kconfig recursive dependency.  This patch chooses to select PPC_CLOCK
>> unconditionally for FSL_SOC to always build clk API for PowerPC in.
>> 
>> Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
>> ---
>> arch/powerpc/Kconfig |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index feab3ba..63fa7fb 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -661,7 +661,7 @@ config SBUS
>> config FSL_SOC
>> 	bool
>> 	select HAVE_CAN_FLEXCAN if NET && CAN
>> -	select PPC_CLOCK if CAN_FLEXCAN
>> +	select PPC_CLOCK
>> 
>> config FSL_PCI
>>  	bool
>> -- 
>> 1.7.5.4
>>