[alsa-devel] [PATCH 1/5] ASoC: sh: fsi: add fsi-codec card support

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Tue Apr 3 02:14:50 CEST 2012


Hi Mark

Thank you for checking patch


> > --- /dev/null
> > +++ b/sound/soc/sh/fsi-codec.c
> 
> A more descriptive name (even if it's just fsi-simple-codec or
> something) would be nice.

OK.

> > +	if (pinfo->codec_fmt) {
> 
> > +	if (pinfo->cpu_fmt) {
> 
> I'd expect that these should always be the same, it's probably as well
> to just have one format and then require anyone who wants anything
> unusual to handle it.

I very agree :)
Thank you for pointing out it.
I fix it in v2

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list