[alsa-devel] [PATCH] ASoC: Ensure we generate a card name

Takashi Iwai tiwai at suse.de
Tue Sep 20 15:30:11 CEST 2011


At Tue, 20 Sep 2011 14:20:02 +0100,
Mark Brown wrote:
> 
> On Tue, Sep 20, 2011 at 03:02:22PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > It might not be used by ALSA but it's used by some userspaces to
> > > identify the card they're running on.
> 
> > The card->name can contain special letters.  This has been so for over
> > a decade, and won't be changed.  Why now need to change this?
> 
> I'm not suggesting that it should?

OK, then I misunderstood the context.  It wasn't clear to me.

>  To be honest I'm quite surprised
> that the alsa-lib code isn't able to cope with spaces in the driver
> name in the first places, I'd rather just fix the specific characters it
> doesn't like.

Spaces may be handled actually, but it'll become tricky by quoting.
It's just like a shell script programming - spaces make harder to
handle in the end.  So, it should be avoided if possible.


Takashi


More information about the Alsa-devel mailing list