[alsa-devel] [PATCH] alsa-lib: if card driver name is empty string, use card name instead

[Scott Jiang]

2011/9/20 Takashi Iwai <tiwai at suse.de>:
> At Tue, 20 Sep 2011 14:37:04 +0800,
> Scott Jiang wrote:
>>
>> 2011/9/20 Takashi Iwai <tiwai at suse.de>:
>> > At Tue, 20 Sep 2011 13:15:44 -0400,
>> > Scott Jiang wrote:
>> >>
>> >> Some drivers don't have a card driver name, but they have a nice card name containing enough info.
>> >> So we can use card name to search card config if we found driver name is not valid.
>> >>
>> >> Signed-off-by: Scott Jiang <scott.jiang.linux at gmail.com>
>> >
>> > It's rather a bug of driver, no?
>> > I don't think we need to work around it.
>> >
>> Mark said it's a bug of app..., he believes driver has provided enough
>> info in card name.
>
> No, the driver name should be set, too.
>
I agree with you, but my driver patch has been rejected by Mark.

On Fri, Sep 16, 2011 at 11:53:16AM +0800, Scott Jiang wrote:
> 2011/9/15 Mark Brown <broonie at opensource.wolfsonmicro.com>:
> > On Wed, Sep 14, 2011 at 11:27:28AM +0800, Scott Jiang wrote:


> >> in alsa lib snd_config_hook_load_for_all_cards(), use
> >> sndrv_ctl_card_info->driver to determine card config,
> >> not sndrv_ctl_card_info->name, though card name contains enough info.

> > So the issue isn't that the driver doesn't have a name, it's that you
> > don't like the name it was given.

> Do you mean alsa lib needs to modify its way to determine which card
> config to load?
> I don't think alsa lib guys will agree.


Well, that's one option.


> >The changelog needs to explain this,
> > and also explain why this is an issue in this one driver.

> Not only for this one driver, it's a problem for all drivers under
> asoc. Because sndrv_ctl_card_info->driver is an empty string now.


So if that's the case then it seems very clear that a driver specific
change isn't a good way of addressing the issue.  If the driver name is
null it actually seems like modifying userspace should be very easy, we
simply need to fall back to reading the card name if the driver name is
empty.