[alsa-devel] Lost dB volumes on USB headset between 2.6.38 and 3.0

[Colin Guthrie]

Hi,

Sorry I only just got around to looking at kernel stuff today, but when
I checked with my 3.0.4 kernel which is now installed it seems fixed!

Cheers!

Col

'Twas brillig, and Takashi Iwai at 18/08/11 17:18 did gyre and gimble:
> At Tue, 16 Aug 2011 13:31:52 +0100,
> Colin Guthrie wrote:
>>
>>> diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
>>> index c04d7c7..cdd19d7 100644
>>> --- a/sound/usb/mixer.c
>>> +++ b/sound/usb/mixer.c
>>> @@ -152,6 +152,7 @@ static inline void check_mapped_dB(const struct usbmix_name_map *p,
>>>  	if (p && p->dB) {
>>>  		cval->dBmin = p->dB->min;
>>>  		cval->dBmax = p->dB->max;
>>> +		cval->initialized = 1;
>>>  	}
>>>  }
>>>  
>>> @@ -1092,7 +1093,7 @@ static void build_feature_ctl(struct mixer_build *state, void *raw_desc,
>>>  				" Switch" : " Volume");
>>>  		if (control == UAC_FU_VOLUME) {
>>>  			check_mapped_dB(map, cval);
>>> -			if (cval->dBmin < cval->dBmax) {
>>> +			if (cval->dBmin < cval->dBmax || !cval->initialized) {
>>>  				kctl->tlv.c = mixer_vol_tlv;
>>>  				kctl->vd[0].access |= 
>>>  					SNDRV_CTL_ELEM_ACCESS_TLV_READ |
>>
>>
>>
>> Not had a chance to test this yet but I will when I get a moment.
> 
> Any chance to test the patch?
> 
> 
> Takashi


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]