[alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM

[Ashish Chavan]

On Fri, 2011-10-21 at 09:58 +0100, Mark Brown wrote:
> On Thu, Oct 20, 2011 at 07:32:49PM +0530, Ashish Chavan wrote:
> > This patch adds support for DAPM covering all inputs and outputs
> > as well as ADC and DAC.
> 
> This patch doesn't apply against current code.

Some how I am unable to sync my tree right now. BTW I re-tested it and
it applies fine on my tree. I am assuming that your tree has my earlier
patches for mute controls and ALC applied.

Is there web interface to your tree? so that I can introspect your
version of da7210.c file to find out what is going wrong? Or any other
way to get your version of that file?


> 
> > +/*
> > + * DAPM Controls
> > + *
> > + * Current DAPM implementation covers almost all codec components e.g. IOs,
> > + * mixers, PGAs,ADC and DAC.
> 
> This explanation would better placed next to the code in the probe -
> it's that code which looks out of place in a Linux driver.
>