[alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM

[Ashish Chavan]

On Fri, 2011-10-21 at 09:58 +0100, Mark Brown wrote:
> On Thu, Oct 20, 2011 at 07:32:49PM +0530, Ashish Chavan wrote:
> > This patch adds support for DAPM covering all inputs and outputs
> > as well as ADC and DAC.
> 
> This patch doesn't apply against current code.

That's strange! Let me recheck to see if I messed anything.

> 
> > +/*
> > + * DAPM Controls
> > + *
> > + * Current DAPM implementation covers almost all codec components e.g. IOs,
> > + * mixers, PGAs,ADC and DAC.
> 
> This explanation would better placed next to the code in the probe -
> it's that code which looks out of place in a Linux driver.

Only problem with that is the code to enable individual IOs is not at
one place and is scattered in the probe(). Should I place all such
things in a single block in probe() and put the comment above that?


Thanks,

-- Ashish (GNU FAN)