[alsa-devel] [PATCH v4 3/7] ASoC: da7210: Add support for mute and zero cross controls

[Ashish Chavan]

On Mon, 2011-10-17 at 22:42 +0100, Mark Brown wrote:
> On Sat, Oct 15, 2011 at 02:53:15PM +0530, Ashish Chavan wrote:
> 
> > +	SOC_SINGLE("ADC Left Capture Switch", DA7210_ADC, 2, 1, 0),
> > +	SOC_SINGLE("ADC Right Capture Switch", DA7210_ADC, 6, 1, 0),
> 
> I'd really expect this to be a single stereo control.
> 

Yes, I will update it to be a single stereo control.

I would also like to get clarified on one potential naming conflict. As
per your comments to first version of this patch, I renamed Mic and Aux2
mute controls as,

	SOC_DOUBLE_R("Mic Capture Switch", ...),
	SOC_SINGLE("Aux2 Capture Switch", ...),

Now I have realized that this may cause a naming conflict with my
"mic_aux_inpga" patch, which I am going to submit after DAPM issues get
sorted. In "mic aux inpga" patch there are controls for Mic and Aux2
volume control,

	SOC_DOUBLE_R_TLV("Mic Capture Volume", ...),
	SOC_SINGLE_TLV("Aux2 Capture Volume", ...),

As per my view, "Mic Capture Volume" is correct name for Mic volume
control and we need to change name for Mic mute control. Do you agree?
If yes, any suggestion for the name of Mic mute control?


Thanks,

-- Ashish (GNU FAN)