[alsa-devel] [PATCH v2] ASoC: Add support for cs42l73 codec

[Mark Brown]

On Tue, Oct 04, 2011 at 05:53:10PM +0000, Austin, Brian wrote:
> On Oct 2, 2011, at 1:40 PM, Mark Brown wrote:
> > On Fri, Sep 30, 2011 at 11:41:52AM -0500, Brian Austin wrote:

> >> +	SOC_DOUBLE("ADC Boost Switch", CS42L73_ADCIPC, 2, 6, 1, 0),

> > This should be a Volume control with TLV information assuming it does
> > what it sounds like and makes the signal louder.

> This is just 0dB or 25dB so now it's just an enum if that's OK.

No, you can still show the gain with TLV information so it renders
nicely in UIs.

> >> +	SOC_SINGLE("HL Limiter Release Rate Volume", CS42L73_LIMRRATEHL, 0,
> >> +			0x3F, 0),

> > Similarly here, you probably want an enumaration showing the rates.

> This is a range of values that are used to set the rate by setting the step period size.
> It's values are 0 - 3F.  I'm hoping to leave it as an SOC_SINGLE control if possible

Well, you should certainly drop the "Volume" from the name.