[alsa-devel] [PATCH resend] ALSA: firewire-speakers: fix locking

[Clemens Ladisch]

Stefan Richter wrote:
> On Oct 03 Takashi Iwai wrote:
>> Stefan Richter wrote:
>>> There is a lock inversion between fwspk->mutex and pcm->open_mutex
>>> reported by lockdep when fwspk_hw_free is called.
>>
>> We should put cc to stable kernel, right?
>
> I am not sure.  While I could reproduce the lockdep report reliably at
> device unplugs, I never encountered a deadlock.

The reported scenario requires that the same PCM device is freed twice
at the same time, which is prevented by the file reference counting.

Going through the entire dependency chain would require the device being
unplugged, being independently close()d, and a ioctl being called with
a swapped-out data buffer all happening at the same time.

This doesn't look like an actual problem.


Regards,
Clemens