[alsa-devel] [PATCH] ASoC: Tegra: Add support of tegra boards basedon ALC5632 codec
Leon Romanovsky
leon at leon.nu
Sun Nov 27 09:37:43 CET 2011
On Wed, Nov 23, 2011 at 19:37, Stephen Warren <swarren at nvidia.com> wrote:
> Leon Romanovsky wrote at Wednesday, November 23, 2011 1:05 AM:
>> Marc Dietrich wrote:
>> > I still don't see how the hp gpio detect comes in. Can you explain this?
>>
>> The detection itself is done via soc-jack interface.
>
> I think Marc wanted to know how the driver knows which GPIO to use, and
> where it sets up use of that GPIO. The Tegra+WM8903 machine driver does
> the following, which I think is missing from this driver:
I removed it from our code before patch, because it didn't work as
expected. There is no reason to push the non-working parts.
Our main reason of this merge is to receive guidance from community on
"correct" way of implementing.
>
> tegra_wm8903_hp_jack_gpio.gpio = pdata->gpio_hp_det;
>
> (I hope to review your patch myself later today)
>
> --
> nvpublic
>
>
--
Leon Romanovsky | Independent Linux Consultant
www.leon.nu | leon at leon.nu
More information about the Alsa-devel
mailing list