[alsa-devel] [PATCH 2/2] ASoC: sdp4430: Fix Panda support

[Girdwood, Liam]

On 21 November 2011 13:38, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Mon, Nov 21, 2011 at 03:14:06PM +0200, Peter Ujfalusi wrote:
>
>> -     if (!machine_is_omap_4430sdp())
>> +     if (machine_is_omap_4430sdp())
>> +             snd_soc_sdp4430.name = "OMAP4 SDP";
>> +     else if (machine_is_omap4_panda())
>> +             snd_soc_sdp4430.name = "OMAP4 Panda";
>> +     else
>
> I'm not thrilled by this given that I'd imagine this'll end up like
> Beagle and have lots of derivatives.  Why not just change the string to
> be something generic along the lines of "OMAP4 audio reference design"
> rather than the name of a particular board?
>

Alsa-lib and also UCM need the string name to load the correct init +
configuration files.

I don't anticipate it growing too much, as we should be able to pull
this out of device tree soon.

Liam