[alsa-devel] [PATCH 2/2] ASoC: sdp4430: Fix Panda support

[Ujfalusi, Peter]

On Mon, Nov 21, 2011 at 3:38 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Mon, Nov 21, 2011 at 03:14:06PM +0200, Peter Ujfalusi wrote:
>
>> -     if (!machine_is_omap_4430sdp())
>> +     if (machine_is_omap_4430sdp())
>> +             snd_soc_sdp4430.name = "OMAP4 SDP";
>> +     else if (machine_is_omap4_panda())
>> +             snd_soc_sdp4430.name = "OMAP4 Panda";
>> +     else
>
> I'm not thrilled by this given that I'd imagine this'll end up like
> Beagle and have lots of derivatives.  Why not just change the string to
> be something generic along the lines of "OMAP4 audio reference design"
> rather than the name of a particular board?

Not sure how to handle this...
Panda does not have Digital Mic, analog Main/Sub mic, and Vibra support in HW.
Panda is simple in terms of audio. SDP is more like reference design
with all possible
audio connection.
When I add UCM profiles for SDP/Panda they should be different (due to
different HW), and the best
way is to have different card names for them.
But they can share the same machine driver, since SDP just have more features.

-- 
Péter