[alsa-devel] smatch stuff in new Cirrus Logic CS42L73 driver

Dan Carpenter dan.carpenter at oracle.com
Fri Nov 18 09:39:22 CET 2011


Hi Brian,

Smatch complains about some stuff in sound/soc/codecs/cs42l73.c.  I
don't know the code well enough to say what was intended.

sound/soc/codecs/cs42l73.c +1030 cs42l73_set_dai_fmt(53) error: inv is never equal to 1024 (wrong type 0 - 255).
sound/soc/codecs/cs42l73.c +1032 cs42l73_set_dai_fmt(55) error: inv is never equal to 768 (wrong type 0 - 255).
sound/soc/codecs/cs42l73.c +1036 cs42l73_set_dai_fmt(59) error: inv is never equal to 1024 (wrong type 0 - 255).
sound/soc/codecs/cs42l73.c +1105 cs42l73_pcm_hw_params(18) info: why not propagate 'mclk_coeff' from cs42l73_get_mclk_coeff() instead of -22?

regards,
dan carpenter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20111118/56872591/attachment.sig 


More information about the Alsa-devel mailing list