[alsa-devel] [PATCH] ASoC: Fix wrong data type access in a few codec drivers

[Stephen Warren]

Jarkko Nikula wrote at Friday, May 13, 2011 8:24 AM:
> Commit fafd217 ("ASoC: Store a list of widgets in a DAPM mux/mixer
> kcontrol")
> changed the control private data type that is passed to snd_soc_cnew when
> creating dapm mixer and mux controls. Commit did not update a few codec
> drivers that are using their own put callbacks and thus are accessing a
> wrong data type.
> 
> Signed-off-by: Jarkko Nikula <jhnikula at gmail.com>
> Cc: Stephen Warren <swarren at nvidia.com>

Crap, sorry about that.

I think this needs to be fixed in a few more places:
wm8994_put_hp_enum
wm8994_put_class_w
wm8995_put_class_w

based on: cd sound/soc && grep -HrnI snd_kcontrol_chip .
... and finding all those that look up widgets not a codec.

Otherwise, on Tegra+WM8903, I repro'd the bug, and tested the fix, so:

Tested-by: Stephen Warren <swarren at nvidia.com>

-- 
nvpublic