[alsa-devel] [PATCH 1/6] OMAP4: HDMI: Add OMAP device for HDMI audio CPU DAI

[Ricardo Neri]

Hi Mark,

Thanks for your comments!

Am Donnerstag, den 05.05.2011, 03:17 -0500 schrieb Mark Brown:
> On Thu, May 05, 2011 at 02:21:48AM -0500, Ricardo Neri wrote:
> 
> > +#if defined(CONFIG_SND_OMAP_SOC_OMAP4_HDMI) || \
> > +	defined(CONFIG_SND_OMAP_SOC_OMAP4_HDMI_MODULE)
> 
> Why is this conditional...
> 
> >  	platform_device_register(&omap_mcbsp1);
> >  	platform_device_register(&omap_mcbsp2);
> >  	if (cpu_is_omap243x() || cpu_is_omap34xx() || cpu_is_omap44xx()) {
> 
> ...but this not?
The device is specific to OMAP4. I added the #if because I think the
device should be built only if HDMI audio option is selected. Also, the
rest of the devices are conditionally built with CONFIG_SND_SOC option.
Do you think I should use cpu_is_omap44xx() instead? In that case, the
hdmi-audio-dai will be built even if HDMI audio option is not selected.