On Wed, May 04, 2011 at 09:45:19PM +0800, Lu Guanqun wrote: > + ret = snd_soc_add_controls(codec, > + mrst_snd_controls, > + ARRAY_SIZE(mrst_snd_controls)); > + if (ret) > + return ret; > + It'd be better to use the data based init stuff to add the controls.