[alsa-devel] [PATCH 03/19] ASoC: mrst_machine: add moorestown machine driver

[Lu Guanqun]

On Wed, May 04, 2011 at 10:55:17PM +0800, Dimitris Papastamos wrote:
> On Wed, May 04, 2011 at 09:45:09PM +0800, Lu Guanqun wrote:
> > This machine driver glues upd9976 codec driver and sst_platform driver.
> > 
> > Signed-off-by: Lu Guanqun <guanqun.lu at intel.com>
> > Signed-off-by: Wang Xingchao <xingchao.wang at intel.com>
> 
> > +static int mrst_hw_params(struct snd_pcm_substream *substream,
> > +			  struct snd_pcm_hw_params *params)
> > +{
> > +	struct snd_soc_pcm_runtime *rtd = substream->private_data;
> > +	struct snd_soc_dai *codec_dai = rtd->codec_dai;
> > +	int ret;
> > +
> > +	ret = snd_soc_dai_set_fmt(codec_dai,
> > +				  SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM);
> > +
> > +	return ret;
> > +}
> 
> Should we not be letting know the CPU that the CODEC is master?  Or is
> it by default slave?

by default, the corresponding bit is 0 and it's slave mode. we should
change it to master somewhere. no sure about your first question...

> 
> Thanks,
> Dimitris
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

-- 
guanqun