[alsa-devel] [PATCH 10/16] ALSA: VIA HDA: Add support for VT1705

[Takashi Iwai]

At Mon, 21 Mar 2011 15:32:26 +0800,
Lydia Wang wrote:
> 
> +/* add playback controls from the parsed DAC table */
> +static int vt1705_auto_create_multi_out_ctls(struct via_spec *spec,
> +					     const struct auto_pin_cfg *cfg)
> +{
> +	char name[32];
> +	static const char * const chname[3] = { "Front", "Surround", "C/LFE" };
> +	hda_nid_t nid_vols[] = {0x10, 0x11, 0x25};
> +	hda_nid_t nid_mutes[] = {0x1C, 0x18, 0x27};

So... this function is identical with others except for the NID array
contents and the max number of channels (up to 6).  Can we merge them
with some additional parameters instead of adding yet-another-new one?


thanks,

Takashi