[alsa-devel] [PATCH 7/16] ALSA: VIA HDA: Modify notify_aa_path_ctls() function

Takashi Iwai tiwai at suse.de
Mon Mar 21 12:08:19 CET 2011


At Mon, 21 Mar 2011 08:32:43 +0100 (CET),
Jaroslav Kysela wrote:
> 
> On Mon, 21 Mar 2011, Lydia Wang wrote:
> 
> > From: Lydia Wang <lydiawang at viatech.com.cn>
> > Subject: ALSA: VIA HDA: Modify notify_aa_path_ctls() function.
> >
> > Modify notify_aa_path_ctls() function to get volume control items name
> > dynamically instead of by giving static item name.
> 
> This code looks ugly to me. If you like to have a dynamic set of notified 
> controls, create one using snd_array in via_spec.

Agreed.  The current code is too fragile.


thanks,

Takashi


More information about the Alsa-devel mailing list