[alsa-devel] [PATCH v3] ASoC: Add TI tlv320aic32x4 codec support.

[Mark Brown]

On Wed, Mar 02, 2011 at 02:52:32PM +0100, Javier Martin wrote:
> This patch adds support for tlv320aic3205 and tlv320aic3254 codecs.
> It doesn't include miniDSP support for aic3254.
> 
> Signed-off-by: Javier Martin <javier.martin at vista-silicon.com>

I've applied this, thanks.

One thing which can be dealt with incrementally:

> +	/* Do DACs need to be swapped? */
> +	if (aic32x4->swapdacs) {
> +		snd_soc_write(codec, AIC32X4_DACSETUP, AIC32X4_LDAC2RCHN | AIC32X4_RDAC2LCHN);
> +	} else {
> +		snd_soc_write(codec, AIC32X4_DACSETUP, AIC32X4_LDAC2LCHN | AIC32X4_RDAC2RCHN);
> +	}

These should be runtime controlled: in the cases where you use it to get
a mic channel from left to right or vice versa you often have two mics
you need to swap between rather than a single static configuration (eg,
built in plus headset).