[alsa-devel] [PATCH] ALSA: hda - apply CS420X erratum fix for CS4207 only

Austin, Brian Brian.Austin at cirrus.com
Thu Mar 3 19:49:42 CET 2011


So the verb sequence that this refers to needs to be done _before_ the
controls are built.  If the controls are built, then this sequence can
clobber some outputs and inputs.  It's my fault, I didn¹t put this code in
the correct place. This sequence should go into the beginning of
cs_build_controls() so that it is run before build_output and build_input
are called.

I can make the changes to fix this.

Thanks again for the help
Brian

On 3/3/11 8:20 AM, "Takashi Iwai" <tiwai at suse.de> wrote:

>At Thu, 03 Mar 2011 19:37:52 +0530,
>Arun Raghavan wrote:
>> 
>> On Thu, 2011-03-03 at 14:58 +0100, Takashi Iwai wrote:
>> > At Thu, 03 Mar 2011 17:50:22 +0530,
>> > Arun Raghavan wrote:
>> > > 
>> > > On Thu, 2011-03-03 at 13:01 +0100, Takashi Iwai wrote:
>> > > > At Thu,  3 Mar 2011 03:18:18 +0530,
>> > > > Arun Raghavan wrote:
>> > > > > 
>> > > > > From: Arun Raghavan <arun at accosted.net>
>> > > > > 
>> > > > > The commit a769cbcf60cee51f4431c0938acd39e7e5b76b8d
>> > > > >     ALSA: hda - Add errata initverb sequence for CS42xx codecs
>> > > > > applies a fix for a chip erratum that is specific to CS4207
>> > > > > unconditionally. On CS4206, this causes digital output to never
>>be
>> > > > > activated.
>> > > > 
>> > > > It might be the power-state the verb table sets?
>> > > > Try to comment out only the line setting SPDIF Tx to D3,
>> > > >   {0x08, AC_VERB_SET_POWER_STATE, 0x03}
>> > > > instead of disabling the whole verbs, just for testing.
>> > > 
>> > > Indeed, this also works.
>> > 
>> > OK, to be sure, try the patch below.
>> 
>> Yep, works just fine.
>
>Thanks for checking.  Merged now to sound git tree.
>
>
>Takashi
>




More information about the Alsa-devel mailing list