[alsa-devel] [PATCH] SOUND: Fix non-ISA_DMA_API build failure

[Takashi Iwai]

At Fri, 24 Jun 2011 14:08:18 +0100,
Ralf Baechle wrote:
> 
> On Fri, Jun 24, 2011 at 02:22:41PM +0200, Takashi Iwai wrote:
> 
> > >  o The drivers/media/radio/Kconfig part should be applied for 3.0 and
> > >    maybe -stable.
> > 
> > Yes, this will be good.
> 
> I just tested that segment only and it works as expected.  Will repost in
> a minute.

Great, thanks.

> > >  o The sound/isa/Kconfig part is basically only fixing the dependency for
> > >    the Adlib driver allowing it to be built on non-ISA_DMA_API system and
> > >    is material for the next release after 3.0.
> > 
> > Any serious reason that snd-adlib must be built even with ISA=n?
> 
> Definately not.
> 
> > As the device is really present only for ISA, it doesn't make much
> > sense to build this even though the driver itself doesn't need
> > ISA_DMA_API.
> 
> I'm not aware of any systems that could use the Adlib in a ISA=n
> environment.  That's why my patch left the dependency on ISA untouched.

OK, but this would just make things complex, I'm afraid.

Practically the only user of snd-adlib is the old x86 with ISA
support, which implies ISA_DMA_API=y, too.  Thus I don't want to touch
sound/isa/Kconfig just for snd-adlib being built for some funky
Kconfig setup :)


thanks,

Takashi