[alsa-devel] [PATCH] ASoC: sgtl5000: add device tree probe support

[Grant Likely]

On Fri, Jul 29, 2011 at 10:40:51AM +0800, Shawn Guo wrote:
> On Tue, Jul 26, 2011 at 08:55:11PM +0100, Mark Brown wrote:
> > On Fri, Jul 22, 2011 at 12:28:51AM +0800, Shawn Guo wrote:
> > 
> > > It adds device tree probe support for sgtl5000 driver.
> > 
> > Kind of waiting for the device tree people to comment on this...
> > 
> 
> Grant, please?

Acked-by: Grant Likely <grant.likely at secretlab.ca>
> 
> Regards,
> Shawn
> 
> > >  .../bindings/sound/soc/codecs/fsl-sgtl5000.txt     |   11 +++++++++++
> > 
> > I'd expect this can just be put directly under the sound directory.
> > 
> > > +++ b/Documentation/devicetree/bindings/sound/soc/codecs/fsl-sgtl5000.txt
> > > @@ -0,0 +1,11 @@
> > > +* Freescale SGTL5000 Stereo Codec
> > > +
> > > +Required properties:
> > > +- compatible : "fsl,sgtl5000".
> > > +
> > > +Example:
> > > +
> > > +codec: sgtl5000 at 0a {
> > > +	compatible = "fsl,sgtl5000";
> > > +	reg = <0x0a>;
> > > +};
> > 
> > This might get a tiny bit verbose...  I wonder if it makes sense to have
> > some central file for devices with trivial bindings?  But possibly more
> > trouble than it's worth.
> > _______________________________________________
> > devicetree-discuss mailing list
> > devicetree-discuss at lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/devicetree-discuss
> > 
>