[alsa-devel] [PATCH] ASoC: davinci: bug fixes for DM365 voice codec driver

Rajashekhara, Sudhakar sudhakar.raj at ti.com
Wed Jul 20 14:19:34 CEST 2011


Hi Sekhar,

On Wed, Jul 20, 2011 at 17:04:55, Nori, Sekhar wrote:
> Hi Sudhakar,
> 
> On Wed, Jul 20, 2011 at 16:15:30, Rajashekhara, Sudhakar wrote:
> > This patch fixes the following bugs found in DaVinci voice codec driver.
> > 
> > a. According to DM365 voice codec data sheet at [1], before starting
> >    recording or playback, ADC/DAC modules should follow a reset and
> >    enable cycle. Writing a 1 to the ADC/DAC bit in the register resets
> >    the module and clearing the bit to 0 will enable the module. But the
> >    driver seems to be doing the reverse of it.
> > 
> > b. In davinci_vcif_trigger() function, a break() statement was missing
> >    causing the davinci_vcif_stop() function to be called as a fallback
> >    after calling davinci_vcif_start().
> 
> These should be two different patches. Also, please CC the ALSA maintainers.
> 

I'll split the patches and resend them.

Regards,
Sudhakar


More information about the Alsa-devel mailing list