[alsa-devel] [PATCH 3/3] ASoC: Tegra: Implement SPDIF CPU DAI

Liam Girdwood lrg at ti.com
Mon Jul 4 12:10:48 CEST 2011


On 02/07/11 20:16, Mark Brown wrote:
> On Fri, Jul 01, 2011 at 01:56:15PM -0600, Stephen Warren wrote:
> 
>> +struct snd_soc_dai_driver tegra_spdif_dai = {
>> +	.name = DRV_NAME ".0",
> 
> This looks wrong - what's with the .0?  If there can be only one device
> there should be no number, if there can be multiple devices hard coding
> is bad karma.  Either way the number should come from the instantiation.

After this comment has been fixed.

Acked-by: Liam Girdwood <lrg at ti.com>


More information about the Alsa-devel mailing list