[alsa-devel] [PATCH] ALSA: HDA: Fix microphone(s) on Lenovo Edge 13

[Andy Robinson]

On Fri, Jan 28, 2011 at 3:01 AM, Takashi Iwai <tiwai at suse.de> wrote:
> And I hope that we should go further a bit for now -- more clean up of
> the cxt5066 code either checking BIOS pins or hp/mic/spk pre-defined
> pins.  Currently, the code is fairly messy (partly because of olpc
> support), and now is a good chance to improve it a bit more.

The parsing code that was put in place for the CX206xx almost works
for the cxt5066 as well, except that it does not handle inputs
connected to the audio selector. Would it be better to add more
auto-configuration to the cxt5066 code, or to enhance the CX206xx code
to make it work with the cxt5066? I suppose the cxt5066 code is more
mature at this point, so enhancing the cxt5066 code might have less
risk of breaking something.

Also, it looks like there's a bug in cx_auto_check_auto_mic. Both "if"
statements are checking if cfg->inputs[0].pin is an external mic and
cfg->inputs[1].pin is an internal mic. The first one should be doing
the opposite.