[alsa-devel] [PATCH] ALSA: HDA: Fix microphone(s) on Lenovo Edge 13

[Takashi Iwai]

At Thu, 27 Jan 2011 10:37:02 +0100,
David Henningsson wrote:
> 
> >From c8c0ca221b4de97682d2e9e5ad73c0ac6346b398 Mon Sep 17 00:00:00 2001
> From: David Henningsson <david.henningsson at canonical.com>
> Date: Thu, 27 Jan 2011 10:28:46 +0100
> Subject: [PATCH] ALSA: HDA: Fix microphone(s) on Lenovo Edge 13
> 
> BugLink: http://bugs.launchpad.net/bugs/708521
> 
> This Edge 13 model has an internal mic at 0x1a and should
> therefore use the asus quirk.
> 
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
> ---
>  sound/pci/hda/patch_conexant.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index 9867afc..7e1ca43 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -3120,6 +3120,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {
>  	SND_PCI_QUIRK(0x152d, 0x0833, "OLPC XO-1.5", CXT5066_OLPC_XO_1_5),
>  	SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400s", CXT5066_THINKPAD),
>  	SND_PCI_QUIRK(0x17aa, 0x21c5, "Thinkpad Edge 13", CXT5066_THINKPAD),
> +	SND_PCI_QUIRK(0x17aa, 0x21c6, "Thinkpad Edge 13", CXT5066_ASUS),

Can 21c5 and 21c6 be incompatible models?
This should be merged, I guess.

I applided the patch but currently it's for 2.6.39 since CXT5066_ASUS
changes aren't queued for 2.6.38 (as non-trivial changes).

And I hope that we should go further a bit for now -- more clean up of
the cxt5066 code either checking BIOS pins or hp/mic/spk pre-defined
pins.  Currently, the code is fairly messy (partly because of olpc
support), and now is a good chance to improve it a bit more.


thanks,

Takashi