[alsa-devel] [PATCH] ASoC: dapm: Fix race condition in widgets power list creation

Peter Ujfalusi peter.ujfalusi at nokia.com
Tue Jan 18 13:47:17 CET 2011


On 01/18/11 14:26, ext Mark Brown wrote:
>> The snd_soc_dapm_sync is just a wrapper for dapm_power_widgets, right?
>> It (snd_soc_dapm_sync) is used in soc-core:soc_post_component_init.
> 
> You're jumping into the analysis mid-way here again...

Unfortunately yes I did :(

>> Modify the snd_soc_dapm_sync to use the codec->mutex around the
>> dapm_power_widgets call.
> 
> This doesn't sound like the right solution in a multi-CODEC system, DAPM
> will affect multiple devices within the system.

Yes, you are right.

But I think the snd_soc_dapm_sync call in soc_post_component_init can be
removed, since it has been taken care of the snd_soc_dapm_new_widgets
call...
Surely it is not solving the problem, in fact it has nothing to do with
the problem ;)

-- 
Péter


More information about the Alsa-devel mailing list