[alsa-devel] Fix section mismatch in wm8995.c

Takashi Iwai tiwai at suse.de
Tue Jan 11 18:32:32 CET 2011


At Tue, 11 Jan 2011 17:28:40 +0000,
Mark Brown wrote:
> 
> On Tue, Jan 11, 2011 at 06:18:49PM +0100, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > Hrm, it'd be better to find some annotation for the pointer which lets
> > > us have the reference.  We at a higher level only dereference the
> > > pointer from the probe path, preventing the discard isn't a great
> > > solution.
> 
> > Nah, that's way too complex for the time being.  I really prefer a
> > warning-less code for such a case.
> 
> The array is ~25k so it's not a completely trivial amount of memory,
> unfortunately.

Hm.  But, it's same for (some) other codecs, no?
If we do annotate something, we should mark all these at once.

> > The whole __init stuff have lots of potential improvements.  But,
> > improving it would cost pretty much.  And we don't want yet another
> > new annotation...
> 
> Very true.  The other option is to refactor all the data structures to
> appease it which is painful.

Agreed.


Takashi


More information about the Alsa-devel mailing list