On Mon, Jan 10, 2011 at 01:28:33PM -0600, Timur Tabi wrote: > + ret = old = snd_soc_read(codec, reg); > + if (ret < 0) > + return ret; Please don't use multiple assignments in a single statement, it does nothing for legibility.