[alsa-devel] [PATCH v5] ASoC: Add Freescale SGTL5000 codec support
Liam Girdwood
lrg at slimlogic.co.uk
Fri Feb 25 10:13:42 CET 2011
On Thu, 2011-02-24 at 02:08 +0800, zhaoming.zeng at freescale.com wrote:
> From: Zeng Zhaoming <zhaoming.zeng at freescale.com>
>
> Add Freescale SGTL5000 codec support.
> Supported features:
> - line-in and mic input
> - headphone and line-out output
> - line-in bypass ADC and DAC to headphone
> - 16, 20, 24, 32 bit audio
> - 8 ~ 96k sample rates
>
> Signed-off-by: Zeng Zhaoming <zhaoming.zeng at freescale.com>
> ---
> Changes since v4:
> 1. Fix regulator resource leak in sgtl5000_enable_regulators().
> 2. Fix memory leak in ldo_regulator_register() when desc.name malloc failed.
> 3. Del snd_soc_dapm_free() in sgtl5000_remove().
> 4. Correct the typos.
> 5. Replace pr_err() with dev_err in sgtl5000_set_clock().
> 6. Fix code style.
>
> Thanks for the review of Timur, Mark, Sascha and Arnaud.
> ---
> sound/soc/codecs/Kconfig | 5 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/sgtl5000.c | 1512 +++++++++++++++++++++++++++++++++++++++++++
> sound/soc/codecs/sgtl5000.h | 402 ++++++++++++
> 4 files changed, 1921 insertions(+), 0 deletions(-)
>
Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>
Btw, your custom PCM volume controls look similar to the register format
used by AC97 volume controls. Did you try the kcontrol convenience
macros before writing your own control ?
Thanks
Liam
More information about the Alsa-devel
mailing list