[alsa-devel] [PATCH] sound azt3328: add custom AC97 semi-emulation, to be able to use standard ALSA AC97 layer

[Andreas Mohr]

Hi,

On Thu, Feb 17, 2011 at 06:37:11PM +0100, Takashi Iwai wrote:
> At Thu, 17 Feb 2011 00:15:47 +0100,
> Andreas Mohr wrote:
> > @@ -189,6 +195,19 @@
> >  #include <sound/mpu401.h>
> >  #include <sound/opl3.h>
> >  #include <sound/initval.h>
> > +/*
> > + * For now, use AC97 layer in case CONFIG_SND_AC97_CODEC is available.
> > + * If our AC97 emulation turns out to work nicely,
> > + * then make it unconditional and remove old custom AC97 crap
> > + * (and Kconfig-select SND_AC97_CODEC).
> 
> In theory, this causes a problem when you build azt driver into kernel
> and build ac97 as a module.

Ah, darn, right!

> I'd suggest just to select AC97 always, and give some switch (either
> static or dynamic) for AC97 control method.

Will do, thanks!

(I'm preferring compile-time switch)

Andreas Mohr