[alsa-devel] [PATCH v3] ASoC: Add Freescale SGTL5000 codec support

[Mark Brown]

On Wed, Feb 16, 2011 at 04:20:37PM -0600, Timur Tabi wrote:

> > +static int sgtl5000_suspend(struct snd_soc_codec *codec, pm_message_t state)
> > +{
> > +       sgtl5000_set_bias_level(codec, SND_SOC_BIAS_OFF);
> > +
> > +       return 0;
> > +}

> #ifdef CONFIG_PM ?

Should be CONFIG_SUSPEND.

> > +       memcpy((void *)(&sgtl5000_regs[0] + (SGTL5000_DAP_REG_OFFSET >> 1)),
> > +                       sgtl5000_dap_regs,
> > +                       0x3a);

> I don't think you need the "(void *)"

You never need to cast to void in C.  C++ requires this but not C.