[alsa-devel] [PATCH 1/6] ASoC: Tegra: Harmony: Add headphone jack detection
Stephen Warren
swarren at nvidia.com
Fri Feb 4 00:25:04 CET 2011
Mark Brown wrote at Thursday, February 03, 2011 3:36 PM:
> On Thu, Feb 03, 2011 at 01:56:13PM -0700, Stephen Warren wrote:
>
> > +static struct snd_soc_jack harmony_hp_jack;
> > +
>
> Since you've changed to using a platform device you should really be
> dynamically allocating this I guess. But this isn't actually a
> practical problem so not worth caring about.
Uggh. The code may as well be consistent. I'll fix this up and resubmit
if you haven't already applied it.
--
nvpublic
More information about the Alsa-devel
mailing list