[alsa-devel] [PATCH] ALSA: HDA: Realtek: Take vmaster dac from multiout dac list

[David Henningsson]

2011-12-12 18:19, Takashi Iwai skrev:
> At Mon, 12 Dec 2011 18:13:44 +0800,
> David Henningsson wrote:
>> 2011-12-12 17:48, Takashi Iwai skrev:
>>> At Mon, 12 Dec 2011 13:37:41 +0800,
>>> David Henningsson wrote:
>>>> With the auto-parser we can choose the dac nid for vmaster from
>>>> the DACs we already know, instead of hard-coding it. This is more
>>>> future-proof and was actually wrong on one machine.
>>>>
>>>> Reported-by: David Chen<david.chen at canonical.com>
>>>> Signed-off-by: David Henningsson<david.henningsson at canonical.com>
>>> Unfortunately this doesn't work correctly for some codecs.
>>> Codecs like ALC262 have no volume in DAC (e.g. 0x02) but only in mixer
>>> (e.g. 0x0c).
>>>
>>> In future, we should build up the I/O paths like in patch_via.c,
>>> so that such info can be checked more easily.
>>>
>> Ah, of course. Thanks for spotting. I believe the patch should look like
>> the attached one instead, what do you think?
> The check of cfg->line_outs can be skipped.  The primary output must
> be present in any case.  Or, at most, just add a non-zero check for
> cfg->line_out_pins[0].  Otherwise it looks good.

Yeah, I was thinking that too, but then patch_alc662 had the no-hp 
fixup, and with all fixups moving here and there, I decided to better be 
safe than sorry. But I trust you to know better than me, so attaching 
modified patch. :-)

// David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ALSA-HDA-Realtek-Take-vmaster-dac-from-multiout-dac-.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20111212/622ae14c/attachment.patch