[alsa-devel] [PATCH 1/3] ASoC: uda1380: Return proper error in uda1380_modinit failure path

Mark Brown broonie at opensource.wolfsonmicro.com
Sun Dec 4 14:00:18 CET 2011


On Sun, Dec 04, 2011 at 07:35:20PM +0800, Axel Lin wrote:

> +	int ret = 0;
>  #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
>  	ret = i2c_add_driver(&uda1380_i2c_driver);
>  	if (ret != 0)
>  		pr_err("Failed to register UDA1380 I2C driver: %d\n", ret);
>  #endif
> -	return 0;
> +	return ret;

In cases like this where only I2C is supported it's best to just remove
all the ifdefs for I2C completely.


More information about the Alsa-devel mailing list