[alsa-devel] [PATCH v2 1/1] ASoC: soc-core: check rate for symmetry only when pcm is active

[Lars-Peter Clausen]

On 08/24/2011 07:27 PM, Mark Brown wrote:
> On Wed, Aug 24, 2011 at 07:05:35PM +0200, Lars-Peter Clausen wrote:
> 
>> A more sensible solution would in my opinion be to save the current rate in the
>> dai struct itself and not in the pcm struct. Upon opening a stream check for
>> cpu and codec DAI whether they require symmetry. If they do and are active
>> constraint the rate to DAIs rate. This also ensures that if boths DAIs are
>> already active and are running at different rates there will be no valid rate
>> for the new stream.
> 
> We need to store in all three places I think - the symmetry requirement
> can also come from the link itself.  But generally this is what we're
> actually looking for, yes.

It should be sufficient to just store the rate for the cpu and codec DAI.
Though the rate constraint should be applied if either the DAI or the link
wants symmetric rates.