[alsa-devel] [PATCH] Prefer kernel-versioned firmware directory.

[Takashi Iwai]

At Wed, 17 Aug 2011 15:19:23 +1200,
linux at audioscience.com wrote:
> 
> From: Eliot Blennerhassett <eblennerhassett at audioscience.com>
> 
> Different kernel versions may have different driver versions installed,
> which in turn require different firmware versions.
> 
> If /lib/firmware/$(uname -r) exists, use it in preference to the
> generic /lib/firmware.

It's no good idea.  The installation of the firmware has nothing to
do with the running kernel version.  The firmware in kernel-tree may
be installed in the kernel-version specific directory, but it's
basically not for external firmware.

In principle, if a firmware is compatible, you must rename it, e.g.
with a version suffix, etc.  Or, if a firmware is backward compatible,
we may keep using the same name.


thanks,

Takashi

> Signed-off-by: Eliot Blennerhassett <eblennerhassett at audioscience.com>
> ---
>  configure.in |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/configure.in b/configure.in
> index c278987..ac9ee52 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -33,7 +33,9 @@ AM_CONDITIONAL(BUILD_FW, test "$buildfw" = "yes")
>  AC_MSG_CHECKING(firmware installation directory)
>  # where to put the firmware. If none of these is right, can specify where
>  # --with-hotplug-dir
> -if test -d /lib/firmware ; then
> +if test -d /lib/firmware/$(uname -r) ; then
> +	detected_fwdir="/lib/firmware/$(uname -r)"
> +elif test -d /lib/firmware ; then
>  	detected_fwdir="/lib/firmware"
>  elif test -d /lib/hotplug/firmware ; then
>  	detected_fwdir="/lib/hotplug/firmware"
> -- 
> 1.7.0.4
>