[alsa-devel] [PATCH - usb 1/1] Terratec Aureon 7.1 USB ID added for C-Media cm6206 quirks

[Paul Menzel]

Dear Wolfgang,


Am Donnerstag, den 28.04.2011, 16:18 +0200 schrieb wbreyha at gmx.net:
> From: Wolfgang Breyha <wbreyha at gmx.net>

the commit summary can also be in present tense.

> Hi!
> 
> This patch adds support for the
> Terratec Aureon 7.1 USB
> which uses a C-Media cm6206 and needs all the quirks already found in the past.

Maybe add a not if everything is working with this patch or if there are
still unsupported things.

> Greetings,
> Wolfgang Breyha

The salutations are not so good for a proper commit message.

> Signed-off-by: Wolfgang Breyha <wbreyha at gmx.net>
> 
> diff --git a/sound/usb/format.c b/sound/usb/format.c
> index 5b792d2..f079b5e 100644
> --- a/sound/usb/format.c
> +++ b/sound/usb/format.c
> @@ -176,9 +176,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof
>  			if (!rate)
>  				continue;
>  			/* C-Media CM6501 mislabels its 96 kHz altsetting */
> +			/* Terratec Aureon 7.1 USB C-Media 6206, too */
>  			if (rate == 48000 && nr_rates == 1 &&
>  			    (chip->usb_id == USB_ID(0x0d8c, 0x0201) ||
> -			     chip->usb_id == USB_ID(0x0d8c, 0x0102)) &&
> +			     chip->usb_id == USB_ID(0x0d8c, 0x0102) ||
> +			     chip->usb_id == USB_ID(0x0ccd, 0x00b1)) &&

Should the IDs be sorted? Maybe put the comments what device this is
right before the ID?

>  			    fp->altsetting == 5 && fp->maxpacksize == 392)
>  				rate = 96000;
>  			/* Creative VF0470 Live Cam reports 16 kHz instead of 8kHz */
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 355759b..916b6a4 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -533,6 +533,7 @@ int snd_usb_apply_boot_quirk(struct usb_device *dev,
>  
>  	case USB_ID(0x0d8c, 0x0102):
>  		/* C-Media CM6206 / CM106-Like Sound Device */
> +	case USB_ID(0x0ccd, 0x00b1): /* Terratec Aureon 7.1 USB */

Should this be sorted too?

>  		return snd_usb_cm6206_boot_quirk(dev);
>  
>  	case USB_ID(0x133e, 0x0815):


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20110428/2f53fc4d/attachment-0001.sig