[alsa-devel] [Patch v2 1/6] ASoC: Tegra: wm8903 probe: Don't call machine_is_*()

Liam Girdwood lrg at slimlogic.co.uk
Wed Apr 20 13:35:03 CEST 2011


On Tue, 2011-04-19 at 15:25 -0600, Stephen Warren wrote:
> This machine driver is a platform driver, and hence will only be
> instantiated on the correct machines. Hence, there is no need to
> check the current machine during probe.
> 
> (Applying Mark's TrimSlice review comments to the existing driver)
> 
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
>  sound/soc/tegra/tegra_wm8903.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/sound/soc/tegra/tegra_wm8903.c b/sound/soc/tegra/tegra_wm8903.c
> index 37f6010..1eb0632 100644
> --- a/sound/soc/tegra/tegra_wm8903.c
> +++ b/sound/soc/tegra/tegra_wm8903.c
> @@ -391,13 +391,6 @@ static __devinit int tegra_wm8903_driver_probe(struct platform_device *pdev)
>  	struct tegra_wm8903_platform_data *pdata;
>  	int ret;
>  
> -	if (!machine_is_harmony() && !machine_is_ventana() &&
> -	    !machine_is_seaboard() && !machine_is_kaen() &&
> -	    !machine_is_aebl()) {
> -		dev_err(&pdev->dev, "Not running on a supported board!\n");
> -		return -ENODEV;
> -	}
> -
>  	pdata = pdev->dev.platform_data;
>  	if (!pdata) {
>  		dev_err(&pdev->dev, "No platform data supplied\n");

All

Acked-by: Liam Girdwood <lrg at ti.com>



More information about the Alsa-devel mailing list