[alsa-devel] [PATCH] ASoC: Remove excessively verbose logging on I2C write

Liam Girdwood lrg at slimlogic.co.uk
Tue Apr 5 09:33:57 CEST 2011


On Mon, 2011-04-04 at 14:57 +0900, Mark Brown wrote:
> We don't need to log every I2C transfer, and certainly not at error level.
> 
> Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
> ---
>  sound/soc/soc-cache.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c
> index 22b0990..5655fce 100644
> --- a/sound/soc/soc-cache.c
> +++ b/sound/soc/soc-cache.c
> @@ -245,7 +245,6 @@ static unsigned int do_i2c_read(struct snd_soc_codec *codec,
>  	xfer[1].buf = data;
>  
>  	ret = i2c_transfer(client->adapter, xfer, 2);
> -	dev_err(&client->dev, "i2c_transfer() returned %d\n", ret);
>  	if (ret == 2)
>  		return 0;
>  	else if (ret < 0)

Acked-by: Liam Girdwood <lrg at ti.com>



More information about the Alsa-devel mailing list