[alsa-devel] [PATCH 1/3 v3] alsa-lib: fixed coverity reported issues under "FORWARD_NULL" checker.

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Apr 4 13:49:15 CEST 2011


On Mon, Apr 04, 2011 at 12:35:11PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > > -	if (h == NULL)
> > > +	if (h)
> > >  		snd_dlclose(h);

> > This is a coding style change, the two conditions are equivalent.

> I thought too at the first glance ;)
> It's the advantage of a systematic check.

Hrm, yes.  Actually the issue here was that due to many of the other
changes I was reading very quickly - the patch looks a lot like a
misfiring automation.


More information about the Alsa-devel mailing list