[alsa-devel] [PATCH 3/3 v3] alsa-lib: fixed coverity reported issues under "USE_AFTER_FREE" checker.

[Paul Menzel]

Dear Sudarshan,


Am Montag, den 04.04.2011, 11:53 +0300 schrieb sudarshan.bisht at nokia.com:

[…]

> diff --git a/src/mixer/simple_abst.c b/src/mixer/simple_abst.c
> index 9e9aaf5..dd0dfa3 100644
> --- a/src/mixer/simple_abst.c
> +++ b/src/mixer/simple_abst.c
> @@ -336,6 +336,8 @@ int snd_mixer_simple_basic_register(snd_mixer_t
> *mixer,
>                 err = find_module(class, top);
>         if (err >= 0)
>                 err = snd_mixer_attach_hctl(mixer, priv->hctl);
> +               if (err < 0) 
> +                        goto __error;          

There are still trailing white spaces at the end of both lines. The
following command should show these to you with red color.

	git log -p --color-words

>         if (err >= 0) {
>                 priv->attach_flag = 1;
>                 err = snd_mixer_class_register(class, mixer);


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20110404/4216f73a/attachment.sig