[alsa-devel] [PATCH 3/3] ASoC: Clean up the CODEC device as well as the board for SMDK WM9713

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Sep 24 14:01:40 CEST 2010


On Fri, Sep 24, 2010 at 08:10:50PM +0900, Jassi Brar wrote:
> On Fri, Sep 24, 2010 at 6:22 PM, Mark Brown

> > Could you be more specific about what other changes you believe are
> > needed?

> IIUIC, the aim of this patch is to be able to reload the module, which isn't
> going to work simply with this chage - we need to do as well something
> about the 'soc-audio' platform device added the first time ?
> So IMHO, this change is a right step but not enough.

As I said in reply to your earlier mail the pre-existing code in the
driver already does that:

--- a/sound/soc/s3c24xx/smdk_wm9713.c
+++ b/sound/soc/s3c24xx/smdk_wm9713.c
@@ -95,6 +95,7 @@ err:
 static void __exit smdk_exit(void)
 {
        platform_device_unregister(smdk_snd_ac97_device);

This preexisting line from the context is cleaning up the soc-audio
device.

+       platform_device_unregister(smdk_snd_wm9713_device);

This new line cleans up the wm9713-codec device which is also added in
the probe function (yay AC'97!).

Reloading the module works, I've been doing that rather a lot.


More information about the Alsa-devel mailing list