[alsa-devel] [PATCH] ASoC: Fix incorrect parameter to snd_soc_codec_volatile_register

Liam Girdwood lrg at slimlogic.co.uk
Thu Sep 23 19:36:52 CEST 2010


On Wed, 2010-09-22 at 16:16 +0100, Dimitris Papastamos wrote:
> We need to pass the register index and not the register value.
> This patch depends on my previous patch "ASoC: Delegate to hw
> specific read for volatile registers".
> 
> Signed-off-by: Dimitris Papastamos <dp at opensource.wolfsonmicro.com>
> ---
>  sound/soc/soc-cache.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c
> index 5d9d2f8..3e4680b 100644
> --- a/sound/soc/soc-cache.c
> +++ b/sound/soc/soc-cache.c
> @@ -177,7 +177,7 @@ static int snd_soc_8_8_write(struct snd_soc_codec *codec, unsigned int reg,
>  	data[0] = reg;
>  	data[1] = value & 0xff;
>  
> -	if (!snd_soc_codec_volatile_register(codec, value) &&
> +	if (!snd_soc_codec_volatile_register(codec, reg) &&
>  		reg < codec->driver->reg_cache_size)
>  			cache[reg] = value;
>  

Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk



More information about the Alsa-devel mailing list