[alsa-devel] [PATCH 2/4 v2] ASoC: Add sh_mobile_hdmi sound support

[Guennadi Liakhovetski]

On Mon, 6 Sep 2010, Mark Brown wrote:

> On Mon, Sep 06, 2010 at 10:27:56AM +0200, Guennadi Liakhovetski wrote:
> > On Tue, 31 Aug 2010, Kuninori Morimoto wrote:
> 
> > > +static int sh_hdmi_snd_write(struct snd_soc_codec *codec,
> > > +			     unsigned int reg,
> > > +			     unsigned int value)
> > > +{
> > > +	struct sh_hdmi *hdmi = snd_soc_codec_get_drvdata(codec);
> > > +
> > > +	hdmi_write(hdmi, value, reg);
> > > +	return 0;
> > > +}
> 
> > Are these two actually needed? As long as you don't have a register cache 
> > - no need for these?
> 
> Something needs to translate the ASoC register I/O functions into what
> the HDMI layer code is expecting.

AFAICS, with ->reg_cache_size = 0 the ASoC core will not attempt to call 
them.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/