[alsa-devel] [PATCH v5 1/9] davinci: EMAC support for Omapl138-Hawkboard

[Victor Rodriguez]

On Thu, Oct 28, 2010 at 9:04 AM, Nori, Sekhar <nsekhar at ti.com> wrote:
> Hi Victor,
>
> Sorry for jumping late on this. Some comments below:
> On Tue, Oct 19, 2010 at 23:36:19, vm.rod25 at gmail.com wrote:
>> From: Victor Rodriguez <victor.rodriguez at sasken.com>
>>
>> This patch adds EMAC support for the Hawkboard-L138 system
>>
>> Signed-off-by: Victor Rodriguez <victor.rodriguez at sasken.com>
>> ---
>>  arch/arm/mach-davinci/board-omapl138-hawk.c |   47 +++++++++++++++++++++++++++
>>  1 files changed, 47 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c
>> index c472dd8..8633245 100644
>> --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
>> +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
>> @@ -19,6 +19,51 @@
>>
>>  #include <mach/cp_intc.h>
>>  #include <mach/da8xx.h>
>> +#include <mach/mux.h>
>> +
>> +#define HAWKBOARD_PHY_ID             "0:07"
>> +
>> +static short omapl138_hawk_mii_pins[] __initdata = {
>> +     DA850_MII_TXEN, DA850_MII_TXCLK, DA850_MII_COL, DA850_MII_TXD_3,
>> +     DA850_MII_TXD_2, DA850_MII_TXD_1, DA850_MII_TXD_0, DA850_MII_RXER,
>> +     DA850_MII_CRS, DA850_MII_RXCLK, DA850_MII_RXDV, DA850_MII_RXD_3,
>> +     DA850_MII_RXD_2, DA850_MII_RXD_1, DA850_MII_RXD_0, DA850_MDIO_CLK,
>> +     DA850_MDIO_D,
>> +     -1
>
> -1 need not be a new line. In any case, please include a ',' after it.
>
>> +};
>> +
>> +static __init void omapl138_hawk_config_emac(void)
>> +{
>> +     void __iomem *cfgchip3 = DA8XX_SYSCFG0_VIRT(DA8XX_CFGCHIP3_REG);
>> +     int ret;
>> +     u32 val;
>> +     struct davinci_soc_info *soc_info = &davinci_soc_info;
>> +
>> +     if (!machine_is_omapl138_hawkboard())
>> +             return;
>
> This is not required since this function is called only on
> a hawkboard.
>
> Thanks,
> Sekhar
>
>


Do not worry , and thanks a lot for the comments . I really appreciate it.

Thanks

Sincerely yours

Victor Rodriguez