[alsa-devel] [PATCH 11/25] ASoC: Samsung: Add common I2S driver

[Mark Brown]

On Fri, Oct 22, 2010 at 04:39:05PM +0900, Jassi Brar wrote:
> On Wed, Oct 20, 2010 at 1:01 PM, Mark Brown

> >> +               /* Secondary is at offset MAX_I2S from Primary */
> >> +               str = (char *)smdk_dai[SEC_PLAYBACK].cpu_dai_name;
> >> +               str[strlen(str) - 1] = '0' + MAX_I2S;

> > Hrm, slightly fiddly.  Perhaps we want a function people can call which
> > will generate the secondary DAI name for you?  Might be more directly
> > what people want.

> We already have to decide on platform_device's id in probe while creating the
> secondary dai in CPU driver. So there must exist any such predefined offset in
> the common driver.
> So, I decided to reuse the symbol and save one addition to the API.

Would it not be nicer to give a different name to the DAI?