[alsa-devel] [PATCH] sst: Intel SST audio driver

[Koul, Vinod]

> > > IIRC at least one version had a split where the ALSA integration stuff
> > > was separated out from the underlying DSP interface code - that was
> > > pretty helpful since it helps focus on the ALSA specifics.
> >
> > Yes but that split is no longer there once the clean up patches sit on
> > top because they weren't put together as separate bits. This is exactly
> > the sort of reason I want to get it in staging.
> >
> >
> > > > Agreed, although gstreamer is pretty good at that it would save
> > > > work if it can be partly generic. It's not trivial however because
> > > > the offload
> > >
> > > Plus the fact that not everyone is using gstreamer at the application
> > > level :/
> > >
> > > > interface with suitable firmware loaded does things other than PCM
> > > > and you have very firmware specific interfaces for configuring
> > > > those.
> > >
> > > We ought to be able to come up with something for the core streaming
> > > stuff, though.  Like I say, it's just a nice to have though.
> >
> > I would have thought PCM at least was also going to have some kind of
> > common structure.
> >
> > > I do have some nervousness about the concept of staging for embedded
> > > stuff since I worry that inclusion in staging can send the wrong
> > > message to vendors but that's a completely separate issue to this
> > > driver.
> >
> > Noted. But I'll point you at the SEP driver which did get bogged down
> > for ages for reasons I can't really go into publically, and we
> > therefore pulled out of staging.
> 
> Sorry to be too late to join the review (as I've been too busy and in
> other troubles...)
No problem :)
> 
> SST driver has been once (sort of) posted and reviewed, but stalled
> since then.  But in general I'm not against merging to the sound main
> tree at all.  The only reason that it didn't occur was that the
> activity just stopped somehow.
Takshi, we had fixed the comments given by you and Mark at that time.
Somehow never managed to get bits upstream again.
> 
> Anyway, I'm going to review in the next week or so.  Then maybe we can
> move it to sound/ directory (e.g. creating sound/platform/x86
> directory) before rc1, unless you'd like to keep the stuff rather in
> staging tree.
That would be wonderful :)
Greg was kind enough to stage it in his staging and there is some activity going on there as well.
If you feel this is good enough to go ahead to sound tree, please merge.
We will resolve the comments by you and community as we go forward and also fix the TODOs.

Thanks
Vinod Koul